Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake version in docs #508

Merged
merged 2 commits into from
Jun 20, 2024
Merged

Conversation

Steven-Roberts
Copy link
Collaborator

These also might need updating:

# We use target_sources since target_link_libraries does not work
# as expected with CMake 3.12 (see CMake issues 18090 and 18692).
# TODO(DJG): Update whenever we require CMake 3.14 or newer
target_sources(${_actual_target_name} PRIVATE $<TARGET_OBJECTS:${_tmp}>)

depends_on("[email protected]:", when="~cuda", type="build")
depends_on("[email protected]:", when="+cuda", type="build")

@gardner48
Copy link
Member

These also might need updating:

# We use target_sources since target_link_libraries does not work
# as expected with CMake 3.12 (see CMake issues 18090 and 18692).
# TODO(DJG): Update whenever we require CMake 3.14 or newer
target_sources(${_actual_target_name} PRIVATE $<TARGET_OBJECTS:${_tmp}>)

This has been addressed in #506

depends_on("[email protected]:", when="~cuda", type="build")
depends_on("[email protected]:", when="+cuda", type="build")

The spack package does need to be updated. Spack will prefer new CMake versions which is why this hasn't been an issue.

@Steven-Roberts
Copy link
Collaborator Author

Steven-Roberts commented Jun 19, 2024

The spack package does need to be updated. Spack will prefer new CMake versions which is why this hasn't been an issue.

Can we fix that in this PR? I assume we want

depends_on("[email protected]:", type="build") 

@balos1
Copy link
Member

balos1 commented Jun 19, 2024

It will need to be something like

depends_on("[email protected]:", type="build", when=":7.0.0") 
depends_on("[email protected]:", type="build", when="7.0.0:") 

FWIW, the Spack package in this repo is only used internally for our CI so it doesnt really matter. Additionally, the package needs to actually be synced with the one in Spack proper (and this change needs to be made there too).

@balos1 balos1 added this to the SUNDIALS Next milestone Jun 20, 2024
@gardner48 gardner48 merged commit 83386fc into develop Jun 20, 2024
23 checks passed
@gardner48 gardner48 deleted the maintenance/docs-cmake-version branch June 20, 2024 00:36
gardner48 added a commit that referenced this pull request Jun 20, 2024
Correct required CMake version from 3.12+ to 3.18+

---------

Co-authored-by: David Gardner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants