Talamini/feature/rate dependence #1314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iffness matrix in warm start
…ials so rate independent material signatures are preserved
tupek2
approved these changes
Jan 21, 2025
tupek2
reviewed
Jan 21, 2025
| @@ -358,7 +360,8 @@ double pressure_error() | |||
| solid.completeSetup(); | |||
|
|
|||
| // Perform the quasi-static solve | |||
| solid.advanceTimestep(1.0); | |||
| constexpr double dt = 1.0; | |||
| solid.advanceTimestep(dt); | |||
There was a problem hiding this comment.
might be good at some point to
- Test with varying dt
- Test the adjoint of this kind of material model
There was a problem hiding this comment.
I agree. I'll tackle them in stages.
white238
reviewed
Jan 27, 2025
white238
reviewed
Jan 27, 2025
white238
reviewed
Jan 27, 2025
Co-authored-by: Chris White <[email protected]>
Co-authored-by: Chris White <[email protected]>
ebchin
approved these changes
Jan 30, 2025
There was a problem hiding this comment.
Nice work, @btalamini . Agreed a unified interface would be nice, but it won't happen with this PR.
| /** | ||
| * @brief Linear isotropic hardening law | ||
| */ | ||
| struct LinearHardening { | ||
| double sigma_y; ///< yield strength | ||
| double Hi; ///< Isotropic hardening modulus | ||
| double eta; ///< viscosity for linear rate sensitivity |
| @@ -195,12 +200,12 @@ TEST(J2, Uniaxial) | |||
| double sigma_y = 0.01; | |||
| double Hi = E / 100.0; | |||
|
|
|||
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi}; | |||
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi, .eta = 0.0}; | |||
There was a problem hiding this comment.
I don't see any tests with eta != 0.0. Do we need to add tests for rate-dependent plasticity?
| @@ -198,7 +198,7 @@ TEST(Solid, MultiMaterialWithState) | |||
| constexpr double Hi = E_right / 3.6; | |||
| constexpr double sigma_y = 0.75 * applied_stress; | |||
|
|
|||
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi}; | |||
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi, .eta = 0}; | |||
There was a problem hiding this comment.
Suggested change
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi, .eta = 0}; | |
| Hardening hardening{.sigma_y = sigma_y, .Hi = Hi, .eta = 0.0}; |
Just so it's clear it's a double
| serac::exitGracefully(); | ||
|
|
||
| return 0; | ||
| } |
There was a problem hiding this comment.
I like this example. Very clear to read
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rate dependent material response in the solid mechanics module. These materials take an extra argument, the time increment, so the call looks like
stress = material(state, dt, du_dX, params...);I didn't want to break the interface (yet) and make users change all their existing materials, so I added a new method
setRateDependentMaterial(...)to the solid mechanics module. We can revisit unifying them later once we have some more experience and feedback.The results look good. Here is the force-displacement output of a new example app, uniaxial tension of a bar:
Other notable changes:
examples/directory and made things clearer and easier to replicate for adding new examplestensorsymmetric 3x3 eigensolver