Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move axl mpi to axl #501

Merged
merged 5 commits into from
Apr 4, 2022
Merged

Move axl mpi to axl #501

merged 5 commits into from
Apr 4, 2022

Conversation

mcfadden8
Copy link
Collaborator

@mcfadden8 mcfadden8 commented Apr 1, 2022

This relates to #489
The relates to AXL PR: ECP-VeloC/AXL#129

This is a refactoring step in preparation for being able to
utilize MPI when flushing shared files.
@adammoody
Copy link
Contributor

This one is hard to test until we start to merge things, but we'll want to remember to move this line:

scr/src/axl_mpi.c

@mcfadden8
Copy link
Collaborator Author

mcfadden8 commented Apr 1, 2022

This one is hard to test until we start to merge things, but we'll want to remember to move this line:

scr/src/axl_mpi.c

Nice catch! I mistakenly left that in. I also need to modify the dist script to include MPI=On when building AXL (if needed). Let me change that now

@mcfadden8
Copy link
Collaborator Author

@adammoody, for dist, do I need to create both a noMPI library in addition to one with MPI enabled (similar to what is being done for other libraries like redset and others?

@adammoody
Copy link
Contributor

@adammoody, for dist, do I need to create both a noMPI library in addition to one with MPI enabled (similar to what is being done for other libraries like redset and others?

Yeah, I was just looking at that. I think we will need to create a noMPI section for AXL, since we use AXL in the serial executables, which should not have MPI. Maybe just copy the kvtree pattern again.

This should be easier to test when we merge the AXL PR.

@adammoody adammoody merged commit d3fb8cf into develop Apr 4, 2022
@mcfadden8 mcfadden8 deleted the move-axl_mpi-to-axl branch April 4, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants