Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/rhornung67/fix sycl #112

Merged
merged 4 commits into from
Oct 31, 2024
Merged

Bugfix/rhornung67/fix sycl #112

merged 4 commits into from
Oct 31, 2024

Conversation

rhornung67
Copy link
Member

This PR resolves issues related to RAJAPerf for running GitLab CI SYCL job on corona.

@rhornung67
Copy link
Member Author

rhornung67 commented Oct 29, 2024

@adrienbernede This has been tested in RAJA and RAJAPerf and fixes issues in both with running SYCL CI job on corona in GitLab.

After this is merged, this will need to be pulled in to RAJA develop. We can use this PR as a starting point: LLNL/RAJA#1758

Then, merging RAJA develop into this RAJAPerf PR LLNL/RAJAPerf#480 and we should be good.

Copy link
Member

@adrienbernede adrienbernede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My conclusion was that RAJAPerf needed both RAJA_ENABLE_SYCL and ENABLE_SYCL to work without change to the source.
I was trying to find a solution that does not affect the source so that we can build the last release of RAJAPerf with Spack. If your fix also modifies RAJAPerf build system, then Spack will only be able to build RAJAPerf @ develop.

@rhornung67
Copy link
Member Author

ENABLE_SYCL is not needed and there are no changes to the RAJAPerf source or build system. The issue was the incorrect conditional in the RAJAPerf build_and_test.sh script. There is a RAJAPerf PR that has all GitLab CI working with this branch. When this is merged, other PRs will pull this into RAJA and RAJAPerf.

@rhornung67 rhornung67 merged commit 9634711 into main Oct 31, 2024
@rhornung67 rhornung67 deleted the bugfix/rhornung67/fix-sycl branch October 31, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants