Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pd feature/example/heat conduction greedy #20

Merged
merged 14 commits into from
May 30, 2024
Merged

Pd feature/example/heat conduction greedy #20

merged 14 commits into from
May 30, 2024

Conversation

pravija12345
Copy link
Collaborator

@pravija12345 pravija12345 commented Oct 27, 2023 •
edited
Loading

This pull request introduces several enhancements to the pylibROM library.

Changes Made:

  • Enabled Jupyter notebook support in the project (see README.md for instructions).
  • Added Jupyter notebook examples for Poisson global PROM and DG Euler DMD.
  • Added Jupyter notebook examples for nonlinear elasticity in both DMD and PROM.
  • Added parametric heat conduction DMD and wave equation DMD examples.

@pravija12345 pravija12345 added the RFR Ready for review label Dec 7, 2023
ckendrick
ckendrick requested changes Dec 21, 2023
View reviewed changes
Copy link
Collaborator

@ckendrick ckendrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good and works for me. Just some minor cleanup of the notebooks and adding some of the sample runs to the notebooks would be helpful.

docker/jupyter_pylibROM/Dockerfile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/dmd/nonlinear_elasticity.ipynb Outdated Show resolved Hide resolved
examples/dmd/dg_euler.ipynb Show resolved Hide resolved
ckendrick
ckendrick approved these changes Jan 3, 2024
View reviewed changes
Copy link
Collaborator

@ckendrick ckendrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@ckendrick ckendrick merged commit 78e9756 into main May 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckendrick ckendrick ckendrick approved these changes

@suparnob100 suparnob100 suparnob100 approved these changes

@bumpwy bumpwy Awaiting requested review from bumpwy

@dreamer2368 dreamer2368 Awaiting requested review from dreamer2368

@chldkdtn chldkdtn Awaiting requested review from chldkdtn

@andersonw1 andersonw1 Awaiting requested review from andersonw1

Assignees
No one assigned
Labels
RFR Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pravija12345 @ckendrick @suparnob100