Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory profiler: add support for distconv-enabled layers #2458

Merged
merged 4 commits into from
Jun 28, 2024
Merged

Memory profiler: add support for distconv-enabled layers #2458

merged 4 commits into from
Jun 28, 2024

Conversation

tbennun
Copy link
Contributor

@tbennun tbennun commented Jun 21, 2024

No description provided.

@tbennun tbennun requested review from bvanessen and benson31 June 21, 2024 05:58
@tbennun tbennun requested a review from fiedorowicz1 June 21, 2024 20:21
benson31
benson31 approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@benson31 benson31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/callbacks/memory_profiler.cpp Outdated Show resolved Hide resolved
fiedorowicz1
fiedorowicz1 previously requested changes Jun 24, 2024
View reviewed changes
src/callbacks/memory_profiler.cpp Outdated Show resolved Hide resolved
bvanessen
bvanessen approved these changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@bvanessen bvanessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Feel free to merge if all comments are sufficiently addressed.

@tbennun
Copy link
Contributor Author

tbennun commented Jun 28, 2024

@bvanessen @fiedorowicz1 comment fixed and tested. Can be merged.

@tbennun tbennun requested a review from fiedorowicz1 June 28, 2024 16:48
@bvanessen bvanessen dismissed fiedorowicz1’s stale review June 28, 2024 16:52

Comments were addressed.

@bvanessen bvanessen merged commit fa569da into LLNL:develop Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benson31 benson31 benson31 approved these changes

@bvanessen bvanessen bvanessen approved these changes

@fiedorowicz1 fiedorowicz1 Awaiting requested review from fiedorowicz1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tbennun @bvanessen @benson31 @fiedorowicz1