Laghos comm cali #316
Laghos comm cali #316
Conversation
Merge remote-tracking branch 'upstream/develop' into kripke_comm_cali
Merge branch 'develop' of https://github.com/LLNL/benchpark into kripke_comm_cali
github-actions
bot
added
experiment
| @@ -6,7 +6,7 @@ | |||
| variables: | |||
| timeout: "120" | |||
| scheduler: "slurm" | |||
| sys_cores_per_node: "96" | |||
| sys_cores_per_node: "36" | |||
There was a problem hiding this comment.
Since Magma really does have 96 cores, it's probably best not to change this value and, instead, create a new config for the 36-core system you'll be using.
There was a problem hiding this comment.
@gracenansamba please remove the changes to the magma config from this PR. We should be using the Dane config instead (which I just added - please test).
| @@ -45,7 +45,8 @@ ramble: | |||
| spack: | |||
| packages: | |||
| hypre-omp: | |||
| spack_spec: [email protected] +mpi+openmp+mixedint~fortran{modifier_spack_variant} | |||
| # spack_spec: [email protected] +mpi+openmp+mixedint~fortran{modifier_spack_variant} | |||
There was a problem hiding this comment.
I generally prefer removing code/params that are commented out, but I can see the point in leaving them if it's likely you will revert to the original value at some point in the future. In that case, you may want to add a short comment to that effect This comment applies to several files in this comment, but I'll just note it here.
repo/amg2023/package.py
Outdated
|
|
||
| license("Apache-2.0") | ||
|
|
||
| version("develop", branch="main") | ||
| version("devlop", branch="comm_cali") |
There was a problem hiding this comment.
should be "develop" here.
| "cce": "cray", | ||
| "gcc": "gnu", | ||
| } | ||
|
|
There was a problem hiding this comment.
| variant("caliper", default=False, description="Build Caliper support") | |
| def get_make_config_options(self, spec, prefix): | |
| def yes_no(varstr): | |
| return "YES" if varstr in self.spec else "NO" | |
| options = super(Mfem, self).get_make_config_options(spec, prefix) | |
| caliper_opt = ["MFEM_USE_CALIPER=%s" % yes_no("+caliper"), ] | |
| return options + caliper_opt |
…into laghos_comm_cali
rfhaque
force-pushed
the
laghos_comm_cali
branch
from
c23f9c9
to
f17c109
Compare
rfhaque
force-pushed
the
laghos_comm_cali
branch
from
f17c109
to
20e479f
Compare
…into laghos_comm_cali changes to configs
| @@ -15,6 +15,7 @@ compilers: | |||
| cflags: -g -O2 | |||
| cxxflags: -g -O2 -std=c++17 | |||
| fflags: -g -O2 -hnopattern | |||
| ldflags: {"-ldl"} | |||
There was a problem hiding this comment.
@pearce8 @gracenansamba Had to add ldflags to get laghos running on tioga. The code runs on ruby, lassen and tioga in the mpi mode
Merge branch 'develop' into laghos_comm_cali
Here is the Laghos branch plus the changes I made.
I made changes in repo/mfem, and experiments/laghos/mpi/ramble.yaml
I have attached a link to mfem: https://github.com/gracenansamba/mfem.git