-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reserveCells crashes mint mesh inside Umpire
#1271
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
f25bdc4
Add reproducers for bug crashing UnstructuredMesh::reserveCells().
gunney1 ba90110
Add missing include guard.
gunney1 10972e8
Merge remote-tracking branch 'gh/develop' into bugfix/gunney/ug-immed…
gunney1 0e0d51a
Merge remote-tracking branch 'gh/develop' into bugfix/gunney/ug-immed…
gunney1 2076165
Merge remote-tracking branch 'gh/develop' into bugfix/gunney/ug-immed…
gunney1 c96baed
Work-around for the crash: Use allocate + copy + deallocate.
gunney1 c36ec8c
Disable the work-around and add tests that bypass mint.
gunney1 cdf6ffb
Fix an un-related compile fail in the new test code.
gunney1 681d035
Add test to allocate and reallocate in sidre package.
gunney1 276c37d
Add test that use only Buffer interface, eliminating Views code as
gunney1 cc83e71
Add tests to verify allocate/deallocate works without sidre::Buffer.
gunney1 49abe98
Merge remote-tracking branch 'gh/develop' into bugfix/gunney/ug-immed…
gunney1 b8cf67d
Fix a bug in new test.
gunney1 ccced65
Build Umpire TPL shared in docker.
gunney1 7a449f9
Rebuild docker images with shared Umpire library.
gunney1 5202846
Use new docker images with shared Umpire libs.
gunney1 3aae97a
Backout work-around and remove a redundant test.
gunney1 7c2bcc2
Merge remote-tracking branch 'gh/develop' into bugfix/gunney/ug-immed…
gunney1 6c50977
Guard code for non-Sidre builds.
gunney1 cf9f910
Add comment explaining why new tests are in quest instead of sidre or…
gunney1 e9844ea
Autoformat.
gunney1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. The new images have Umpire shared libs. That's the key to the bug fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@white238 @kennyweiss are you OK with switching to Umpire shared libs for azure testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We (@kennyweiss , @gunney1 , @davidbeckingsale ) met about this last night. Basically a static umpire with a shared axom creates multiple singletons in Umpire. We need to not allow this to happen in our Spack recipe as well but this seems to be the only way around this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean add a constraint in the Axom Spack package that static Umpire conflicts with shared Axom?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes and/or a conflict
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes -- the three of us had a meeting yesterday w/ @davidbeckingsale and concluded that the static umpire combined w/ a shared axom in the docker configuration was leading to more than one umpire instance.
There might be a solution to this w/ improved linking orders and/or linker flags, but it will be difficult to track down in the short term, and is not necessary for @gunney1's actual deliverable (i.e. the CI is testing a different configuration than the one we actually need). @gunney1 is planning to create an issue summarizing that discussion so we can look into it in the future.
It's also worth noting that we've encountered similar issues in the past when mixing libraries w/ singletons with upstream shared or Fortran libraries (e.g. #865 and #270).
Edit: My response took too long and @white238 beat me to the punch