Use dynamically allocated buffer instead of dynamically sized local array in kernel InitLocalMem #1790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the amount of memory is only known at runtime and dynamically sized local arrays are not allowed in c++.
MrBurmark
force-pushed
the
bugfix/burmark1/InitLocalMem
branch
from
5361044 to
447bec4
Compare
MrBurmark
changed the title
artv3
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use dynamically allocated arrays
Use dynamically allocated buffer instead of dynamically sized local array in kernel InitLocalMem.
This is a problem because it is not valid C++ and causes large warnings to be generated when compiling with hip.