PFA annotations #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koparasy
reviewed
Oct 2, 2023
koparasy
reviewed
Oct 2, 2023
koparasy
reviewed
Oct 2, 2023
| @@ -43,6 +43,7 @@ using dt3 = mfem::DeviceTensor<3, T>; | |||
|
|
|||
|
|
|||
| template <typename Tin, typename Tout> | |||
| __attribute__((annotate("@critical_path(pointcut='around')"))) | |||
There was a problem hiding this comment.
Why not using the macro (PERFFASPECT) here?
There was a problem hiding this comment.
The macro was causing error here. I think its scope is within the src directory, though I could be wrong.
koparasy
requested changes
Oct 2, 2023
alizalisan
force-pushed
the
pfa-annotations
branch
from
4b2c958
to
478c298
Compare
alizalisan
force-pushed
the
pfa-annotations
branch
from
65a4093
to
a440129
Compare
alizalisan
force-pushed
the
pfa-annotations
branch
from
a440129
to
ed0581e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request: