Adds -rp parameter and option to run ML model on GPU and physics module on CPU #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koparasy
reviewed
Jan 29, 2024
koparasy
reviewed
Jan 29, 2024
koparasy
reviewed
Jan 29, 2024
koparasy
reviewed
Jan 29, 2024
src/AMSlib/wf/resource_manager.hpp
Outdated
| @@ -145,7 +145,7 @@ class ResourceManager | |||
| static void deallocate(std::vector<T*>& dPtr, AMSResourceType resource) | |||
| { | |||
| for (auto* I : dPtr) | |||
| RMAllocators[resource]->deallocate(I); | |||
| RMAllocators[resource]->deallocate(I, dev); | |||
There was a problem hiding this comment.
I think over here you need to delete "dev".
koparasy
requested changes
Jan 29, 2024
src/AMSlib/wf/workflow.hpp
Outdated
Comment on lines
226
to
244
| // ------------------------------------------------------------- | ||
| // STEP 1: call the hdcache to look at input uncertainties | ||
| // to decide if making a ML inference makes sense | ||
| // ------------------------------------------------------------- | ||
| if (hdcache != nullptr) { | ||
| CALIPER(CALI_MARK_BEGIN("UQ_MODULE");) | ||
| hdcache->evaluate(totalElements, tmpInputs, p_ml_acceptable); | ||
| CALIPER(CALI_MARK_END("UQ_MODULE");) | ||
| } | ||
|
|
||
| DBG(Workflow, "Computed Predicates") | ||
|
|
||
| CALIPER(CALI_MARK_BEGIN("SURROGATE");) | ||
| // We need to call the model on all data values. | ||
| // Because we expect it to be faster. | ||
| // I guess we may need to add some policy to do this | ||
| DBG(Workflow, "Model exists, I am calling surrogate (for all data)"); | ||
| surrogate->evaluate(totalElements, tmpInputs, tmpOutputs); | ||
| CALIPER(CALI_MARK_END("SURROGATE");) |
There was a problem hiding this comment.
Over here we call the model. Giorgis has changed the interfaces. Please study this commit here: 00589c2 . The commit replaces the 2 calls we had on both UQ and Model, with a single one that does both.
koparasy
reviewed
Jan 30, 2024
koparasy
reviewed
Jan 30, 2024
koparasy
reviewed
Jan 30, 2024
koparasy
reviewed
Jan 30, 2024
koparasy
requested changes
Jan 30, 2024
alizalisan
changed the title
koparasy
reviewed
Feb 8, 2024
src/AMSlib/wf/workflow.hpp
Outdated
| if (phLoc != mlLoc) { | ||
| // Copy out the result | ||
| ResourceManager::copy(p_ml_acceptable, _p_ml_acceptable); | ||
| ResourceManager::deallocate(p_ml_acceptable, mlLoc); |
There was a problem hiding this comment.
You deallocate p_ml_acceptable here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.