-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First version with working meson builder configuration, with tests! #15
base: master
Are you sure you want to change the base?
Conversation
Oh I closed by accident haha |
Codecov Report
@@ Coverage Diff @@
## master #15 +/- ##
=======================================
Coverage 71.89% 71.89%
=======================================
Files 10 10
Lines 1327 1327
=======================================
Hits 954 954
Misses 373 373 Continue to review full report at Codecov.
|
Many thanks @AtilaSaraiva , looks good to me! Yes you are right about the Is this PR ready to merge now or is there more work to do on it? Thanks again! |
It is my pleasure! I'd like to check for mistakes before the merge, I'll do it asap. Additionally, I'd like to ask a question, is it possible to use clBlas or other OpenCL libraries from fortran using focal? I thought a simple interface would do it but I'm not so sure, gotta test. Either way, I still have to update the docs to reflect the meson builder addition. I'll try to create some time this week to do that. It is in another repository right? |
Awesome, sounds good! Yes that seems like a possible alternative. |
@LKedward pls do forgive me for my absence, the last few months have been crazy. I added support for generating pkg-config configurations for the library, making it easier for people with different build systems to easily import focal. This will also help me when I ultimately package this for Nix. Now the meson configuration is looking good IMHO! |
Oh I remembered, the .mod files need a special script to be installed, gonna work on that. |
Hello again! I made the working version, I still have some things to do, but all the tests are working. The most troublesome thing is that I had to write a small python script (for portability) to copy the *.cl files to another directory in memory, and then create the *.cl.o files from there with ld, each at their own folder, which is deleted afterwards. This is not ideal but is working.
I'd much rather have the focal library to be able to handle any symbol name.
Either way I will add how to use it on the docs and I thinking about using a simple shell script instead of python, just need to study it a little bit.