Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Chronicle RPC URLs #293

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

alexvotofuture
Copy link
Contributor

Description

Updating Chronicle RPC URLs in the rollup doc page, in both the table on that page and the button that adds it to MetaMask.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Introducing new feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Link to the relevant updated sections in the Netlify preview

  • Link 1: [description of change]
  • Link 2: [...]

Checklist:

General

  • I have performed a self-review of my code
  • I have fixed all grammar issues (can use an AI tool to check), and explanations are in active voice
  • I have checked the additions are concise
  • Language is consistent with existing documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published (ie. SDK changes, node dependencies)

If I have added a new concept, I have

  • included a beginner friendly explanation
  • included a basic technical introduction and code sample
  • new terms are defined, both in relevant new pages and in the glossary

Copy link

netlify bot commented May 28, 2024

Deploy Preview for lit-dev-docs failed.

Name Link
🔨 Latest commit 3c4f37a
🔍 Latest deploy log https://app.netlify.com/sites/lit-dev-docs/deploys/66565e87d9908200080c2f0c

@alexvotofuture
Copy link
Contributor Author

@glitch003 @spacesailor24 for review

Copy link
Contributor

@secretfader secretfader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshLong145
Copy link

joshLong145 commented Jun 5, 2024

@alexvotofuture
Can we fix the build errors and update the branch with master we then can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants