Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Wrapped Keys solana send tx tests #61

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix Wrapped Keys solana send tx tests #61

merged 1 commit into from
Oct 8, 2024

Conversation

spacesailor24
Copy link
Contributor

@spacesailor24 spacesailor24 commented Sep 25, 2024 •
edited
Loading

  • For SOL txs, the response of signTransactionWithEncryptedKey is properly base58 encoded when broadcast is set to true, however it's base64 encoded when broadcast is false
  • The send SOL txs test were previously decoding the response as base64 and then re-encoding to base58
  • Added two new tests for sending the signed SOL txs manually (i.e. broadcast is set to false)

awisniew207
awisniew207 approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@awisniew207 awisniew207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

21 passing, 1 pending

@spacesailor24 spacesailor24 merged commit ea72ff0 into master Oct 8, 2024
@spacesailor24 spacesailor24 deleted the wyatt/fix-sol-wrapped-keys branch October 8, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awisniew207 awisniew207 awisniew207 approved these changes

Assignees

@awisniew207 awisniew207

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spacesailor24 @awisniew207