Skip to content

feat(benches): implement thread binding with hwlocality #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 26, 2025

Conversation

imrn99
Copy link
Collaborator

@imrn99 imrn99 commented May 22, 2025

Description

Scope: benches

Type of change: feat

Content description:

  • add a bind-threads feature to the benchmark crate
  • read number of threads used for each benchmark from env variables
  • read binding policy from env variables
  • add binding function and required feature checks
  • temporarily disable features in CI, will re-enable when I update the CI in another PR

Additional information

  • New dependency: hwlocality

Necessary follow-up

update the CI to enable the bind-threads feature by default in the honeycomb-benches crate

TODO:

  • remove the new feature from default; it is temporarily enabled for my dev env to no lint everything new as deadcode
  • write the actual threadpool init

@imrn99 imrn99 mentioned this pull request May 22, 2025
1 task
@codecov-commenter
Copy link

codecov-commenter commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (41a42e2) to head (fb8653a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #337   +/-   ##
=======================================
  Coverage   87.62%   87.62%           
=======================================
  Files          72       72           
  Lines       11370    11370           
=======================================
  Hits         9963     9963           
  Misses       1407     1407           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@imrn99 imrn99 marked this pull request as ready for review May 26, 2025 07:15
@imrn99 imrn99 requested a review from cedricchevalier19 May 26, 2025 07:15
@imrn99 imrn99 merged commit ea19965 into master May 26, 2025
14 checks passed
@imrn99 imrn99 deleted the thread-binding branch May 26, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants