feat(core): add new dart allocation interfaces #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should heavily simplify dart pre-allocation for parallel task, though the system still needs improvements.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
+ Coverage 84.81% 85.40% +0.59%
==========================================
Files 68 69 +1
Lines 9942 10219 +277
==========================================
+ Hits 8432 8728 +296
+ Misses 1510 1491 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -22,6 +22,11 @@ impl UnusedDarts { | |||
| self.0.extend((0..len).map(|_| TVar::new(false))); | |||
| } | |||
|
|
|||
| /// Extend internal storage capacity using the passed value for new items | |||
| pub fn extend_from_val(&mut self, len: usize, val: bool) { | |||
There was a problem hiding this comment.
Suggested change
| pub fn extend_from_val(&mut self, len: usize, val: bool) { | |
| pub fn extend_with(&mut self, len: usize, val: bool) { |
Not sure about the semantic you want to follow, but this looks closer to what people are doing externally.
There was a problem hiding this comment.
yeah, I have no strong opinion on the naming, doing what others do is probably best
I'll need to properly update everything in a single commit if I want to rebase this tho
sure, I also started to look into CRDTs so maybe this can tie things in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
should be rebased
Scope: core
Type of change: feat
Content description: see commits
Necessary follow-up
There are a few different things possible for improvements before integrating some form of CRDT:
CMaps and only allow aligned block allocations