feat(wm): adds Komorebic taskbar visibility controls #735

LegitCamper · 2024-04-06T22:55:02Z

Adds support for two Komorebic commands ToggleTaskbarVisibility and ShowTaskbar which can either be true or false.
This prevents the need to use alternative tools, and will provide access for ahk scripts to control taskbar visibility.

This is my first real PR so if there is anything weird let me know.

Adds support for two Komorebic command ToggleTaskbarVisibility and ShowTaskbar which can either be true or false. This prevents the need to use alternative tools and will provide access for ahk scripts to control taskbar visibility,

feat(wm): adds Komorebic taskbar visibility controls

LGUG2Z · 2024-04-07T14:42:59Z

Thank you for this contribution, it looks very cool! I'll try this out during the week and flag it to the testers on Discord. If all is good hopefully we can ship this with v0.1.24 🚀

LGUG2Z · 2024-04-07T15:39:42Z

We'll need to update the application exit and stop handlers to restore the taskbar (any change to the system that komorebi makes should be reverted when the process stops)

LGUG2Z · 2024-04-07T16:31:39Z

komorebi-core/src/lib.rs

@@ -88,6 +88,8 @@ pub enum SocketMessage {
    EnsureWorkspaces(usize, usize),
    EnsureNamedWorkspaces(usize, Vec<String>),
    NewWorkspace,
+    ToggleTaskbarVisibility,
+    ShowTaskbar(bool),


Let's change this to Taskbar(Taskbar) where the struct is generated by gen_enum_subcommand_args! using Taskbar: BooleanState; this way the call signature will match focus-follows-mouse (eg. komorebic focus-follows-mouse disable, komorebic taskbar disable)

LGUG2Z · 2024-04-07T16:32:04Z

komorebi-core/src/lib.rs

@@ -88,6 +88,8 @@ pub enum SocketMessage {
    EnsureWorkspaces(usize, usize),
    EnsureNamedWorkspaces(usize, Vec<String>),
    NewWorkspace,
+    ToggleTaskbarVisibility,


This one too we can just shorten to ToggleTaskbar

LGUG2Z · 2024-04-07T16:34:00Z

komorebi/src/windows_api.rs

+                ShowWindow(taskbar_hwnds.0, SHOW_WINDOW_CMD(0));
+                ShowWindow(taskbar_hwnds.1, SHOW_WINDOW_CMD(0));
+            } else {
+                ShowWindow(taskbar_hwnds.0, SHOW_WINDOW_CMD(5));


Let's replace this with the constant from windows-rs https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/UI/WindowsAndMessaging/constant.SW_SHOW.html

LGUG2Z · 2024-04-07T16:34:27Z

komorebi/src/windows_api.rs

+        unsafe {
+            if hide {
+                // 0 hides the taskbar and 5 enables visibility
+                ShowWindow(taskbar_hwnds.0, SHOW_WINDOW_CMD(0));


https://microsoft.github.io/windows-docs-rs/doc/windows/Win32/UI/WindowsAndMessaging/constant.SW_HIDE.html

LGUG2Z · 2024-04-07T22:29:31Z

komorebi/src/process_command.rs

+                    WindowsApi::hide_taskbar((taskbar, startmenu), false);
+                }
+            }
+            SocketMessage::MoveWorkspaceToMonitorNumber(monitor_idx) => {


I think this have been mistakenly duplicated from above

LGUG2Z · 2024-04-07T22:29:56Z

2024-04-07T22:28:52.335619Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:28:59.118943Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:29:02.876010Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)
2024-04-07T22:29:04.672027Z ERROR komorebi::process_command: The operation completed successfully. (os error 0)

This is what I'm getting when running either of the new commands locally from this build 🤔

Tested `komorebic toggle-taskbar`, `komorebic taskbar enable`, and `komorebic taskbar disable`. They all seem to be working. When the taskbar is hiding, safely exiting unhides the taskbar properly.

Insprill · 2024-04-18T15:07:14Z

Would it be worth adding a config option for this? When using Komorebi, I'd like the taskbar to always be hidden, and the only way I see to do that now is to add another command to my startup script to toggle it off.

LGUG2Z · 2024-04-18T15:35:44Z

I'll try building and running this branch again when I get some time; last time I tried it I didn't have any luck. Once the implementation is sound we can definitely look at adding both komorebic and static config options for manipulating the behaviour.

Insprill · 2024-04-18T15:55:42Z

I'm testing this PR now, and it appears to be working fine on my primary monitor, but the taskbar doesn't get hidden on my other two monitors. I don't know what's up with that, as changing the scale of my secondary monitors causes the taskbar to deform like it's ignoring events as if it's supposed to be hidden. However, it still gets updated and is interactable. Reenabling it with komorebic will fix the deformation.

LegitCamper added 2 commits April 6, 2024 16:21

feat(wm): adds Komorebic taskbar visibility controls

611e65f

Adds support for two Komorebic command ToggleTaskbarVisibility and ShowTaskbar which can either be true or false. This prevents the need to use alternative tools and will provide access for ahk scripts to control taskbar visibility,

Merge pull request #1 from LegitCamper/master

daa601d

feat(wm): adds Komorebic taskbar visibility controls

LGUG2Z reviewed Apr 7, 2024

View reviewed changes

LegitCamper added 2 commits April 7, 2024 13:43

fix(wm): renames taskbar enums to be shorter

19ffed2

fix(wm): unhide taskbar during exit

638e280

LGUG2Z reviewed Apr 7, 2024

View reviewed changes

LegitCamper added 2 commits April 8, 2024 00:07

fix(wm): remove duplicate lines

0996580

fix(wm): fix taskbar handle function

f54bcb2

Tested `komorebic toggle-taskbar`, `komorebic taskbar enable`, and `komorebic taskbar disable`. They all seem to be working. When the taskbar is hiding, safely exiting unhides the taskbar properly.

LGUG2Z force-pushed the master branch 3 times, most recently from 11675ef to 6fe4661 Compare April 15, 2024 15:36

LGUG2Z force-pushed the master branch 6 times, most recently from 0c842e4 to 05af7ce Compare May 19, 2024 21:27

LGUG2Z force-pushed the master branch from 10ba89f to 340c137 Compare May 24, 2024 02:00

LGUG2Z force-pushed the master branch from 83272dd to 9e37baa Compare June 21, 2024 03:31

LGUG2Z force-pushed the master branch 2 times, most recently from e6afece to 8ee9116 Compare July 4, 2024 19:42

LGUG2Z force-pushed the master branch 7 times, most recently from 3aff79a to 22c1d5f Compare September 21, 2024 18:49

LGUG2Z force-pushed the master branch 2 times, most recently from 468dcf6 to d110e12 Compare September 24, 2024 22:39

LGUG2Z force-pushed the master branch 6 times, most recently from 26a8912 to 2325d75 Compare October 11, 2024 15:46

LGUG2Z force-pushed the master branch 12 times, most recently from 12870dc to e46a1a6 Compare October 16, 2024 23:15

LGUG2Z force-pushed the master branch 3 times, most recently from ece5a57 to 9a3dbcc Compare November 3, 2024 23:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(wm): adds Komorebic taskbar visibility controls #735

feat(wm): adds Komorebic taskbar visibility controls #735

LegitCamper commented Apr 6, 2024

LGUG2Z commented Apr 7, 2024

LGUG2Z commented Apr 7, 2024

LGUG2Z Apr 7, 2024

LGUG2Z Apr 7, 2024

LGUG2Z Apr 7, 2024

LGUG2Z Apr 7, 2024

LGUG2Z Apr 7, 2024

LGUG2Z commented Apr 7, 2024

Insprill commented Apr 18, 2024

LGUG2Z commented Apr 18, 2024

Insprill commented Apr 18, 2024

feat(wm): adds Komorebic taskbar visibility controls #735

Are you sure you want to change the base?

feat(wm): adds Komorebic taskbar visibility controls #735

Conversation

LegitCamper commented Apr 6, 2024

LGUG2Z commented Apr 7, 2024

LGUG2Z commented Apr 7, 2024

LGUG2Z Apr 7, 2024

Choose a reason for hiding this comment

LGUG2Z Apr 7, 2024

Choose a reason for hiding this comment

LGUG2Z Apr 7, 2024

Choose a reason for hiding this comment

LGUG2Z Apr 7, 2024

Choose a reason for hiding this comment

LGUG2Z Apr 7, 2024

Choose a reason for hiding this comment

LGUG2Z commented Apr 7, 2024

Insprill commented Apr 18, 2024

LGUG2Z commented Apr 18, 2024

Insprill commented Apr 18, 2024