feat(cli/autostart): add --no-console to autostart without a console window
#598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves `komorebic` logic into a `lib.rs` file and calls it from `main.rs` (normal behavior) and then there is a second binary `komorebic-no-console` binary that uses `#![windows_subsystem = "windows"]` which tells the linker to not attach a console window to this binary.
This reverts commit 08494b4.
This creates a second binary `komorebic-no-console` binary that uses `#![windows_subsystem = "windows"]` which tells the linker to not attach a console window to this binary and its only job is to run and pass its args to `komorebic`.
amrbashir
changed the title
--no-console to autostart without a console window
LGUG2Z
reviewed
Dec 2, 2023
|
I think this looks good; let's just drop the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR actually contains two approaches for this in
08494b4ande97aaa3The first one, moves
komorebiclogic into alib.rsfile and calls it frommain.rs(normal behavior) and then there is a second binarykomorebic-no-consolebinary that uses#![windows_subsystem = "windows"]which tells the linker to not attach a console window to this binary.The second one, creates a second binary
komorebic-no-consolebinary that uses#![windows_subsystem = "windows"]which tells the linker to not attach a console window to this binary and its only job is to run and pass its args tokomorebic.Both have benefits and drawbacks, but the main benefit of the second approach (which I recommend anyways) is that it creates a smaller binary and thus doesn't bloat the final installer.