refactor: cleanup path handling #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Avoids unnecessary string allocation when tracing paths - Replaces `mut path & path.push()` with `path.join()` - Avoids unncessary cloning of paths where applicable - Use `dunce` crate to remove `UNC` prefix - Improve performance of resolving `~` by avoiding unnecessary string allocations - Resolve `~`, `$Env:USERPROFILE` and `$HOME` consistenly between different code paths - Use `PathBuf` instead of `String` for paths in CLI args I may have missed a couple of places but I think I covered 90% of path handling in the codebase
|
This looks amazing, I'll read through the changes (and improve my own knowledge 😅) on Monday and aim to get this merged before any additional work on the animations feature. 🤞 |
LGUG2Z
reviewed
Nov 26, 2023
| @@ -1106,15 +1108,48 @@ pub fn send_message(bytes: &[u8]) -> Result<()> { | |||
| Ok(stream.write_all(bytes)?) | |||
| } | |||
|
|
|||
| fn with_komorebic_socket<F: Fn() -> Result<()>>(f: F) -> Result<()> { | |||
|
Looks good and the tests are passing so YOLO 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was just wandering around the codebase to get a bit familiar with it and it turned to a session of small refactors around paths handling.
This PR:
mut path & path.push()withpath.join()which is nicer and more concise and the cost is the same since it was already allocating when cloningduncecrate to removeUNCprefix~by avoiding unnecessary string allocations~,$Env:USERPROFILEand$HOMEconsistenly between different code pathsPathBufinstead ofStringfor paths in CLI argsI may have missed a couple of places but I think I covered 90% of path handling in the codebase