Feature(wm)/stop ignore restore #1186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LGUG2Z
reviewed
Dec 17, 2024
alex-ds13
force-pushed
the
feat(wm)/stop-ignore-restore
branch
from
0c9b3e8 to
580d1d6
Compare
This commit creates a new `SocketMessage` called `StopIgnoreRestore` which makes komorebi stop without calling `window.restore()` on all windows. This way every maximized window will stay maximized once you start komorebi again and it is able to use the previous `State`. If it fails to restore the previous state you might have to call `komorebic restore-windows` in case you had hidden windows, for example when when using the `window_hiding_behaviour` as `Hide`, or you can simply unminimize them if you were using `Cloak` or `Minimize`.
alex-ds13
force-pushed
the
feat(wm)/stop-ignore-restore
branch
from
580d1d6 to
19581d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a new
SocketMessagecalledStopIgnoreRestorewhich makes komorebi stop without callingwindow.restore()on all windows. This way every maximized window will stay maximized once you start komorebi again and it is able to use the previousState.If it fails to restore the previous state you might have to call
komorebic restore-windowsin case you had hidden windows, for example when when using thewindow_hiding_behaviourasHide, or you can simply unminimize them if you were usingCloakorMinimize.This PR is built on top #1185 so it needs to be merged after that one.
@LGUG2Z I've made this just a draft PR so you can give me your feedback and tell me if you think it's fine to add or if you rather not add it to not increase complexity just to appease the needs of one person (that one person being me 😄). I don't think users can use this to shoot themselves on the foot because even if they are using
window_hiding_behaviourasHidethey can always callkomorebic restore-windowsafterwards if for some reason komorebi fails to load their previousState.Also this command is mostly intended for developers that are making changes to komorebi code and need to be restarting it a lot of times.
However I totally understand if you think it's better not to add it. In that case I might keep rebasing this commit on top of master just for me... 😄