Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct typing of exclusive maximums and minimums for draft7 jso… #188

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

dpwdec
Copy link
Contributor

@dpwdec dpwdec commented Jul 9, 2024

It seems like for json schema draft-07 that exclusiveMinimum and exclusiveMaximum are actually values. The current implementation seems to have been done in line with draft-04 which is not supported by AsyncAPI.

Reference: https://json-schema.org/understanding-json-schema/reference/numeric#range

Copy link
Collaborator

@VisualBean VisualBean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch

@VisualBean VisualBean merged commit fb50d00 into LEGO:main Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants