Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge dev to main #82

Merged
merged 27 commits into from
Nov 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
cd80490
Update Dockerfile, environments, schema
Baroquem Oct 6, 2023
1520646
Pin mariadb version to 10.6
Baroquem Oct 6, 2023
41dc735
Update Gemfile & lock
Baroquem Oct 6, 2023
b691738
Extend loc lookup for loc names rdftypes
chrisrlc Oct 31, 2023
be73b21
Add subauthority support for more loc vocabularies and authorities
chrisrlc Oct 31, 2023
c6f8346
Add id uniqueness filter to loc direct lookup output
chrisrlc Oct 31, 2023
5e1a615
Fix rubocop warnings
chrisrlc Oct 31, 2023
8eff316
Don't ignore rubocop configuration in docker container
chrisrlc Nov 1, 2023
6b97f61
Merge pull request #78 from LD4P/loc-lookup
chrisrlc Nov 1, 2023
c7c092e
Revert changes for local copy of qa_server
Baroquem Nov 1, 2023
f7f6608
Add gcompat for architecture independence; update Bundler
Baroquem Nov 1, 2023
7171f36
Merge remote-tracking branch 'origin/dev' into update-gems
Baroquem Nov 1, 2023
f2941ad
Update bixby and appease rubocop
Baroquem Nov 1, 2023
4daf312
Update bixby dependencies in Gemfile.lock
chrisrlc Nov 1, 2023
43cfdfe
Disable Lint/MissingSuper on classes inheriting from qa base parent
chrisrlc Nov 1, 2023
d9f6f2a
Update .env.example
chrisrlc Nov 1, 2023
f3f4077
Update reference to qa_server
Baroquem Nov 10, 2023
e2b4cd1
Update reference to qa_server
Baroquem Nov 10, 2023
f816027
Update reference to qa_server
Baroquem Nov 10, 2023
9b7061b
Merge pull request #79 from LD4P/update-gems
Baroquem Nov 10, 2023
cfd64e6
Apply rails app:update
Baroquem Nov 10, 2023
0feeb77
Appease Rubocop
Baroquem Nov 10, 2023
e7fb51c
Appease Rubocop
Baroquem Nov 10, 2023
458adac
Restore lograge
Baroquem Nov 10, 2023
4e12230
Merge pull request #80 from LD4P/update-app
Baroquem Nov 10, 2023
c13a64f
Bump qa_server to 8.0.1
chrisrlc Nov 15, 2023
f3f350b
Merge pull request #81 from LD4P/qa-server-fix
chrisrlc Nov 15, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .dockerignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
/.git
/.gitignore
/.rspec
/.rubocop*
/.qa_server_app

/coverage/*
Expand Down
4 changes: 2 additions & 2 deletions .env.example
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,10 @@ MYSQL_ROOT_PASSWORD=CHANGEME
## --------------------
PREFERRED_TIME_ZONE_NAME=Eastern Time (US & Canada)
DISPLAY_HISTORICAL_DATA=true
HISTORICAL_DATA_DEFAULT_TIME_PERIOD=:month
HISTORICAL_DATA_DEFAULT_TIME_PERIOD=month
DISPLAY_PERFORMANCE_GRAPH=false
DISPLAY_PERFORMANCE_DATATABLE=false
PERFORMANCE_DATA_DEFAULT_TIME_PERIOD=:month
PERFORMANCE_DATA_DEFAULT_TIME_PERIOD=month
SUPPRESS_PERFORMANCE_LOGGING=true
MONITOR_STATUS_LOGGING_ENABLED=false

Expand Down
10 changes: 7 additions & 3 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
ARG RUBY_VERSION=2.7.3
ARG RUBY_VERSION=3.1.2
FROM ruby:$RUBY_VERSION-alpine
ARG BUNDLER_VERSION=2.3.7

## Install dependencies:
## - build-base: To ensure certain gems can be compiled
Expand All @@ -9,6 +10,7 @@ FROM ruby:$RUBY_VERSION-alpine
## - tzdata: add time zone support
## - mariadb-dev: To allow use of MySQL2 gem
## - imagemagick: for image processing
## - gcompat: to avoid architecture-specific incompatibitilies
RUN apk add --update --no-cache \
bash \
build-base \
Expand All @@ -17,17 +19,19 @@ RUN apk add --update --no-cache \
sqlite-dev \
tzdata \
mariadb-dev \
imagemagick6-dev imagemagick6-libs
imagemagick6-dev imagemagick6-libs \
gcompat


WORKDIR /app/ld4p/qa_server-webapp

RUN gem install bundler:2.1.4
RUN gem install bundler:${BUNDLER_VERSION}

ENV PATH="/app/ld4p/qa_server-webapp:$PATH"
ENV RAILS_ROOT="/app/ld4p/qa_server-webapp"

COPY Gemfile Gemfile.lock ./

RUN gem update --system
RUN bundle install

Expand Down
32 changes: 20 additions & 12 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby '2.7.3'
ruby '3.1.2'

# rubocop:disable Bundler/OrderedGems
## Gems adds by `rails new`
# Bundle edge Rails instead: gem 'rails', github: 'rails/rails'
gem 'rails', '~> 5.2.5'
gem 'rails', '~> 7.0.8'
# Use sqlite3 as the database for Active Record
gem 'sqlite3'
gem 'sqlite3', '~> 1.4.4'
# Use Puma as the app server
gem 'puma', '~> 5.6.4'
gem 'puma', '>= 5.6.4', '~>6.4.0'
# Use SCSS for stylesheets
gem 'sass-rails', '~> 5.0'
# Use Uglifier as compressor for JavaScript assets
Expand All @@ -19,11 +19,11 @@ gem 'uglifier', '>= 1.3.0'
# gem 'mini_racer', platforms: :ruby

# Use CoffeeScript for .coffee assets and views
gem 'coffee-rails', '~> 4.2'
gem 'coffee-rails', '~> 5.0.0'
# Turbolinks makes navigating your web application faster. Read more: https://github.com/turbolinks/turbolinks
gem 'turbolinks', '~> 5'
# Build JSON APIs with ease. Read more: https://github.com/rails/jbuilder
gem 'jbuilder', '~> 2.5'
gem 'jbuilder', '~> 2.10'
# Use Redis adapter to run Action Cable in production
# gem 'redis', '~> 4.0'
# Use ActiveModel has_secure_password
Expand All @@ -36,7 +36,7 @@ gem 'jbuilder', '~> 2.5'
# gem 'capistrano-rails', group: :development

# Reduces boot times through caching; required in config/boot.rb
gem 'bootsnap', '>= 1.1.0', require: false
gem 'bootsnap', '~> 1.16', require: false

group :development, :test do
# Call 'byebug' anywhere in the code to stop execution and get a debugger console
Expand All @@ -46,7 +46,7 @@ end
group :development do
# Access an interactive console on exception pages or by calling 'console' anywhere in the code.
gem 'web-console', '>= 3.3.0'
gem 'listen', '>= 3.0.5', '< 3.2'
gem 'listen', '>= 3.0.5', '< 3.9'
# Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring
gem 'spring'
gem 'spring-watcher-listen', '~> 2.0.0'
Expand All @@ -65,9 +65,12 @@ gem 'tzinfo-data', platforms: [:mingw, :mswin, :x64_mingw, :jruby]

## Gems manually added to for qa and qa_server engines
# Required gems for QA and linked data access
gem 'qa_server', '~> 7.5'
gem 'qa', '~> 5.5'
# NOTE: We need to update the published RubyGems version of qa_server with the 8.0 release. Until
# then, the next entry is set to use the GitHub repo and tag instead.
gem 'qa_server', git: 'https://github.com/LD4P/qa_server.git', tag: 'v8.0.1'
gem 'qa', '~> 5.10'
gem 'linkeddata'
gem 'psych', '~> 5.1'

## Gems added for application customization
# support for .env file
Expand All @@ -87,13 +90,18 @@ group :development, :integration, :test do
end

group :development, :integration do
gem 'xray-rails' # overlay showing which files are contributing to the UI
# gem 'xray-rails' # overlay showing which files are contributing to the UI
# This gem doesn't work with Ruby 3.x unless a special branch is used (see
# https://github.com/brentd/xray-rails/pull/108). There is a PR to merge the fix
# into the master branch, but the gem's authors don't seem to be in a hurry to
# finish the work.
gem "xray-rails", git: "https://github.com/brentd/xray-rails.git", branch: "bugs/ruby-3.0.0"
end

group :development do
gem 'better_errors' # add command line in browser when errors
gem 'binding_of_caller' # deeper stack trace used by better errors
gem 'bixby', '~> 3.0' # style guide enforcement with rubocop
gem 'bixby', '~> 5.0' # style guide enforcement with rubocop
gem 'rubocop-checkstyle_formatter', require: false
end

Expand Down
Loading
Loading