Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install code server #5

Merged
merged 9 commits into from
Feb 17, 2025
Merged

install code server #5

merged 9 commits into from
Feb 17, 2025

Conversation

marc-hanheide
Copy link
Member

This pull request includes a small change to the Dockerfile. The change adds a command to install the Coder software.

  • Dockerfile: Added a command to install Coder software using a curl command.

@marc-hanheide marc-hanheide changed the title install coder install code server Feb 12, 2025
@marc-hanheide
Copy link
Member Author

marc-hanheide commented Feb 12, 2025

@LeonardoGuevara @cooperj

this installs code-server and exposes it as port 9999 on the limo when the container is started.

So, one can directly go to the limo IP at port 9999 and use VSCode in the browser, including terminal etc. And one can therefore also simply execute local code on the robots themselves.

Maybe worth trying on an actual limo, @cooperj ?

@marc-hanheide marc-hanheide marked this pull request as ready for review February 12, 2025 23:29
@marc-hanheide
Copy link
Member Author

I have tested it locally, and I think it's working. There is also a new configs/docker-compose-dev.yaml which can be used to overwrite for development and testing of the config locally, but that's only for anyone developing/testing this repository, and not be used generally.

But with that test, I managed to open http://localhost:9999 and had a nice development environment directly in the container, with all things to install packages etc.

Note: I expose this on port 9999 without any authentication. So, anyone can access the robot container (but only the container!) and mess with it. Which should be fine, as we can simply delete the container and make a new one of it's been messed up.

Copy link
Member

@cooperj cooperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work - when I go to port 9999 I get back an empty response? Is this correct?

@cooperj
Copy link
Member

cooperj commented Feb 14, 2025

limo_drivers-1  | bash: line 1: code-server: command not found

@marc-hanheide
Copy link
Member Author

limo_drivers-1  | bash: line 1: code-server: command not found

No surprise, as we haven't released this PR in the image... if you just run it on the robot for now it will only pull the released (version-ed) image, as it should.

Copy link
Member

@cooperj cooperj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, changes applied as discussed.

configs/docker-compose.yaml Show resolved Hide resolved
@marc-hanheide
Copy link
Member Author

@cooperj I presume you tested on a limo?

@cooperj
Copy link
Member

cooperj commented Feb 17, 2025

@cooperj I presume you tested on a limo?

Correct, working as expected

@marc-hanheide marc-hanheide merged commit aae3c07 into main Feb 17, 2025
1 check passed
@marc-hanheide marc-hanheide deleted the marc-hanheide-patch-coder branch February 17, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants