Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed parameter manager for Monte Carlo runs #1437

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

mrvisscher
Copy link
Collaborator

@mrvisscher mrvisscher commented Jan 23, 2025

Fixed an issue where the MCParameterManager couldn't deal properly with the changed ParameterManager class of last update.

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@mrvisscher mrvisscher requested a review from marc-vdm January 23, 2025 10:01
@mrvisscher mrvisscher added the bug Issues/PRs related to bugs label Jan 23, 2025
@mrvisscher mrvisscher added this to the 2.11.1 milestone Jan 23, 2025
@coveralls
Copy link

Coverage Status

coverage: 53.134% (+0.006%) from 53.128%
when pulling e98bf97 on mrvisscher:fix-paramter-mc
into 3da042e on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm merged commit 344f632 into LCA-ActivityBrowser:main Jan 23, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues/PRs related to bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute error running Montecarlo analysis including parameters
3 participants