Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling updates + wiki page on contributions and sankey #1381

Merged
merged 4 commits into from
Sep 30, 2024

Conversation

marc-vdm
Copy link
Member

@marc-vdm marc-vdm commented Sep 27, 2024

@mrvisscher Please:

  • Update contribution analysis figure for windows
  • Update Sankey figure
    • Install DB below, run calculation with 1 steel and IPCC 2021
    • Screenshot result (or save as .svg and edit to reasonable size
  • Store screenshots in docs/wiki/assets, overwrite current files.

wiki_ca_example.xlsx

Checklist

If you have write access (otherwise a maintainer will do this for you):

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, feature, ui, change, documentation, breaking, ci
    as they show up in the changelog.
  • Add a milestone to the PR (and related issues, if any) for the intended release.
  • Request a review from another developer.

@marc-vdm marc-vdm added the documentation PRs that refer to documentation at any level (code, readthedocs, etc.) label Sep 27, 2024
@coveralls
Copy link

coveralls commented Sep 27, 2024

Coverage Status

coverage: 54.26% (+0.03%) from 54.228%
when pulling 903add2 on marc-vdm:lca_results_wiki
into 9d4a1c4 on LCA-ActivityBrowser:main.

@marc-vdm marc-vdm linked an issue Sep 29, 2024 that may be closed by this pull request
@marc-vdm marc-vdm mentioned this pull request Sep 29, 2024
7 tasks
@mrvisscher mrvisscher marked this pull request as ready for review September 30, 2024 10:51
Copy link
Collaborator

@mrvisscher mrvisscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mrvisscher mrvisscher merged commit 3168835 into LCA-ActivityBrowser:main Sep 30, 2024
7 checks passed
@marc-vdm marc-vdm deleted the lca_results_wiki branch September 30, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation PRs that refer to documentation at any level (code, readthedocs, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write contribution analysis wiki section
3 participants