-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic linting #1310
base: main
Are you sure you want to change the base?
Automatic linting #1310
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest adding a pre-commit [1] hook for ruff [2], to avoid wasting time (both from a devex and CI perspective).
[1] - https://pre-commit.com/
[2] - https://github.com/astral-sh/ruff-pre-commit?tab=readme-ov-file#using-ruff-with-pre-commit
with: | ||
args: check --fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with: | |
args: check --fix |
Probably don't want to fix on CI, but on the pre-commit hook maybe?
Btw it's a good idea to set your editor (and CI) to ensure files end with a \n
[1].
Checklist
bug
,feature
,ui
,change
,documentation
,breaking
,ci
as they show up in the changelog.