View factors are now calculated correctly.

LBNL-ETA · Nov 8, 2024 · f0d1866 · f0d1866
1 parent dbec8f5
commit f0d1866
Show file tree

Hide file tree

Showing 3 changed files with 67 additions and 68 deletions.
diff --git a/src/SingleLayerOptics/src/VenetianCellDescription.cpp b/src/SingleLayerOptics/src/VenetianCellDescription.cpp
@@ -150,7 +150,8 @@ namespace SingleLayerOptics
                                                            const CBeamDirection & t_Direction)
     {
         // clang-format off
-        const auto bvf{cellBeamViewFactors(t_Side, t_Direction)};
+        auto bvf{cellBeamViewFactors(t_Side, t_Direction)};
+
         return Helper::visibleSegmentPercentage(
                                           beamViewFactorsToBeamSegmentViews(
                                               numberOfSegments(),
@@ -199,9 +200,7 @@ namespace SingleLayerOptics
       CVenetianCellDescription::cellBeamViewFactors(double t_ProfileAngle,
                                                     FenestrationCommon::Side t_Side)
     {
-        const auto profileAngle{t_Side == FenestrationCommon::Side::Front ? t_ProfileAngle
-                                                                          : -t_ProfileAngle};
-        return m_BeamGeometry.beamViewFactors(-profileAngle, t_Side);
+        return m_BeamGeometry.beamViewFactors(-t_ProfileAngle, t_Side);
     }
 
     std::vector<Viewer::BeamViewFactor>