Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a couple issues with the auto-detection of the NVCC_GENCODE in NCCL #2459

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Fix a couple issues with the auto-detection of the NVCC_GENCODE in NCCL #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/superbuild/nccl/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ endmacro ()

lbann_sb_init_extern_pkg(
NAME NCCL
LANGUAGES C CXX # CUDA <- can't set explicitly; inferred from ${CUDA_HOME}
LANGUAGES C CXX CUDA
GITHUB_URL NVIDIA/nccl
GIT_TAG "master")

Expand Down Expand Up @@ -105,8 +105,8 @@ if (LBANN_SB_FWD_NCCL_NVCC_GENCODE)
elseif (DEFINED $ENV{NVCC_GENCODE})
set(_nccl_nvcc_gencode_opt
"NVCC_GENCODE=$ENV{NVCC_GENCODE}")
elseif (LBANN_NCCL_CUDA_ARCHITECTURES)
set(_cuda_arch ${LBANN_NCCL_CUDA_ARCHITECTURES})
elseif (LBANN_SB_NCCL_CUDA_ARCHITECTURES)
set(_cuda_arch ${LBANN_SB_NCCL_CUDA_ARCHITECTURES})
set(_nccl_nvcc_gencode_opt
"NVCC_GENCODE=-gencode=arch=compute_${_cuda_arch},code=sm_${_cuda_arch}")
else ()
Expand Down
Loading