Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Optical Element - Intensity Mask #357

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

New Optical Element - Intensity Mask #357

wants to merge 4 commits into from

Conversation

AnnaLiisaP
Copy link

Adds functionality to mask out the intensity of different regions of the beam. This could for example be used to mimic the effect of an aperture or a optic with a hole ( see issue #345)

rob-shalloo
rob-shalloo reviewed Feb 14, 2025
View reviewed changes
Copy link
Member

@rob-shalloo rob-shalloo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for this PR! It's a great new feature!

I would consider adding some more context to the docstring (I've made a suggestion).
Additionally, I think that the aperture_type is confusing if one of the types is aperture and the other is hole, and so I suggest changing the variable name from aperture_type to mask_type.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rob-shalloo rob-shalloo rob-shalloo left review comments

@MaxThevenet MaxThevenet Awaiting requested review from MaxThevenet

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnaLiisaP @rob-shalloo