Allows reading laser envelope from Wake-T #356
+30
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxThevenet
reviewed
Feb 18, 2025
| @@ -68,29 +68,32 @@ def __init__(self, wavelength, pol, array, dim, axes, axes_order=["x", "y", "t"] | |||
| ) | |||
| else: # dim = "rt" | |||
| assert axes_order in [["r", "t"], ["t", "r"]] | |||
| assert len(array.shape) == 3, "Field array is not 3D." | |||
There was a problem hiding this comment.
With these changes, can we still read FBPIC output successfully? And use lasy as we do for the FBPIC-Wake-T handshake?
| @@ -75,8 +79,10 @@ def __init__( | |||
| field, | |||
| coord=None, | |||
| is_envelope=None, | |||
| is_waket=None, | |||
There was a problem hiding this comment.
For the record: we do this at the moment, but before the next release we need to make sure the code work without such a specific option.
| else: | ||
| s = io.Series(path + "/" + prefix + "_%T.h5", io.Access.read_only) | ||
| if is_waket: | ||
| filepath = path + "/" + prefix + "%T.h5" |
There was a problem hiding this comment.
This maybe should be fixed in Wake-T.
Comment on lines
+133
to
+134
| if field == "a": | ||
| array = (m_e * c * omg0 / e) * array |
There was a problem hiding this comment.
Could you use vector_potential_to_field instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading Wake-T files with
FromOpenPMDProfilewas not working well.This PR includes a patch to make it work.
It may serve as a basis to discuss a better and more general implementation of
FromOpenPMDProfileandFromArrayProfileclasses.angularFrequencyattribute in the hdf5 file, which is very specific forLASYenvelope files only. Now, a new variableis_waketcan be passed toFromOpenPMDProfileto read the Wake-T file. We should generalize the method. In the meantime this serves as a patch.FromArrayProfile, which still treated the field array as 2D in some cases. This PR implement that the field array is always 3D.angularFrequencyis calculated when reading from a non-envelope laser file, such as the ones provided by FBPIC. In these cases,FromOpenPMDProfileobtains the central frequency with thefield_to_envelopemethod. However, I have observed non-sensical values of this parameter. This affected the vector potential,a, to electric field,E, envelope transformation when reading Wake-T files, which needs the right value for the central angular frequency of the laser.atoEtransformation when reading from Wake-T envelope files, and to circumvent the problem on the previous point, this PR allowslambda0to be passed directly toFromOpenPMDProfile, so this value will be used instead of the one calculated byfield_to_envelope.