Closes #215 , add overloading for addition and multiplication operators in TransverseProfile #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
rob-shalloo
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…-shalloo/lasy into overloadingTransverseProfile
|
I think it would make sense to add some basic testing for these function. It would be good to have at least something like this. |
for more information, see https://pre-commit.ci
…-shalloo/lasy into overloadingTransverseProfile
for more information, see https://pre-commit.ci
…-shalloo/lasy into overloadingTransverseProfile
|
Hey @soerenjalas , thanks for the great suggestion. I've added the tests now, again shamelessly copying your code... but seems to work ;) |
soerenjalas
approved these changes
Dec 21, 2023
MaxThevenet
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've followed @soerenjalas implementation of overloading in the Profile class and added it directly in the TransverseProfile class. This allows one to create a laser transverse profile from a sum of hermite gaussians without having to first create the full laser object. This makes things cleaner and should hopefully speed up calculations.
This should close #215