Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new get_spectrum and get_duration utils #168

Merged
merged 33 commits into from
Aug 23, 2023

Conversation

AngelFP
Copy link
Member

@AngelFP AngelFP commented Aug 18, 2023

As the title says, this PR adds two new laser analysis methods. They currently support grids that contain an envelope. In addition to them, a new convenience method to get the grid cell volume has also been implemented.

lasy/utils/laser_utils.py Fixed Show fixed Hide fixed
lasy/utils/laser_utils.py Fixed Show fixed Hide fixed
lasy/utils/laser_utils.py Fixed Show fixed Hide fixed
Copy link
Contributor

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this PR! See comments below.

lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Fixed Show fixed Hide fixed
lasy/utils/laser_utils.py Fixed Show fixed Hide fixed
tests/test_laser_utils.py Fixed Show fixed Hide fixed
tests/test_laser_utils.py Fixed Show fixed Hide fixed
tests/test_laser_utils.py Fixed Show fixed Hide fixed
@AngelFP
Copy link
Member Author

AngelFP commented Aug 22, 2023

New approach using spectral density (squaring the FFT amplitude to get J/(rad/s)).
on axis:
image

summed:
image

Copy link
Contributor

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the tests and extensive docstrings! See minor points below.

lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
lasy/utils/laser_utils.py Outdated Show resolved Hide resolved
AngelFP and others added 3 commits August 23, 2023 16:27
Co-authored-by: Maxence Thévenet <[email protected]>
Co-authored-by: Maxence Thévenet <[email protected]>
Co-authored-by: Maxence Thévenet <[email protected]>
@MaxThevenet MaxThevenet merged commit ab536da into LASY-org:development Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants