Skip to content
This repository has been archived by the owner on Apr 20, 2024. It is now read-only.

Dependency Upgrades #219

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Dependency Upgrades #219

merged 2 commits into from
Nov 13, 2023

Conversation

Kyrluckechuck
Copy link
Owner

Description

Bumps all the dependencies since it's been a while! 😅

@Kyrluckechuck
Copy link
Owner Author

Doing further testing with this, as it appears it is unable to get past League client is not open, attempting to start it when using these versions 🤔

@Kyrluckechuck Kyrluckechuck marked this pull request as draft November 13, 2023 00:54
@Kyrluckechuck
Copy link
Owner Author

Ah, ended up being an issue with #218, where switching subprocess.run needed to be replaced with subprocess.Popen 🤦‍♂️

@Kyrluckechuck Kyrluckechuck marked this pull request as ready for review November 13, 2023 01:21
@Kyrluckechuck Kyrluckechuck merged commit cdcb8f6 into main Nov 13, 2023
5 checks passed
@Kyrluckechuck Kyrluckechuck deleted the dependency-upgrades branch November 13, 2023 01:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant