Created getUser() method #85

StavrosNik4 · 2022-11-26T09:52:25Z

I made a getUser method to scrap information, stats etc about a user.
It was also requested in #63
I didn't make a data user model because I'm not familiar with TypeScript, I hope someone else can do it.
My method still works.

Kylart

Thank you for this! I tested it and it works fine!

I added some changes, some of them can be committed as is if you like them, otherwise we can discuss them.

Also, please add some tests for your feature in the test folder.

Kylart · 2022-11-28T00:33:03Z

src/users.js

+  const pfp = $('#content .user-image img') // getting the profile picture page section
+  const status1 = $('#content .user-profile .user-status-title') // getting the status titles page section
+  const status2 = $('#content .user-profile .user-status-data') // getting the status data page section
+  const result = [] // we will put here all the properties of the final object
+  // pushing some basic properties and values
+  result.push({ Username: name })
+  result.push({ ProfilePictureLink: $(pfp).attr('data-src').trim() })
+  result.push({ LastOnline: $(status2[0]).text() })
+  // loop for the status
+  let i = 1
+  const arrayLength = status1.length
+  while (i < arrayLength - 1) {
+    const val = $(status1[i]).text()
+    switch (val) {
+      case 'Gender':
+        result.push({
+          Gender: $(status2[i]).text()
+        })
+        break
+      case 'Birthday':
+        result.push({
+          Birthday: $(status2[i]).text()
+        })
+        break
+      case 'Location':
+        result.push({
+          Location: $(status2[i]).text()
+        })
+        break
+      case 'Joined':
+        result.push({
+          Joined: $(status2[i]).text()
+        })
+    }
+    i++
+  }


Suggested change

const pfp = $('#content .user-image img') // getting the profile picture page section

const status1 = $('#content .user-profile .user-status-title') // getting the status titles page section

const status2 = $('#content .user-profile .user-status-data') // getting the status data page section

const result = [] // we will put here all the properties of the final object

// pushing some basic properties and values

result.push({ Username: name })

result.push({ ProfilePictureLink: $(pfp).attr('data-src').trim() })

result.push({ LastOnline: $(status2[0]).text() })

// loop for the status

let i = 1

const arrayLength = status1.length

while (i < arrayLength - 1) {

const val = $(status1[i]).text()

switch (val) {

case 'Gender':

result.push({

Gender: $(status2[i]).text()

})

break

case 'Birthday':

result.push({

Birthday: $(status2[i]).text()

})

break

case 'Location':

result.push({

Location: $(status2[i]).text()

})

break

case 'Joined':

result.push({

Joined: $(status2[i]).text()

})

}

i++

}

const pfp = $('#content .user-image img') // getting the profile picture page section

const statusTitles = $('#content .user-profile .user-status-title') // getting the status titles page section

const statusData = $('#content .user-profile .user-status-data') // getting the status data page section

const result = [] // we will put here all the properties of the final object

// pushing some basic properties and values

result.push({ Username: name })

result.push({ ProfilePictureLink: $(pfp).attr('data-src').trim() })

result.push({ LastOnline: $(statusData[0]).text() })

statusTitles.each(function (index, status) {

result.push({

[$(status).text()]: $(statusData[index]).text()

})

})

I don't think that's a good solution. Here are the results from my account:

Well then, just add a filter on $(status).text() to have only the ones you want

Is there a different way in JS to do that or do I need to add just an if statement?

Nevermind, just added it on d357f88

Kylart · 2022-11-28T00:34:54Z

src/users.js

+  // putting all the properties and values to one object
+  const finalObj = {}
+  for (let i = 0; i < result.length; i++) {
+    Object.assign(finalObj, result[i])
+  }
+  return finalObj


Just make result an object from the start et add properties instead of pushing them.

That was a good point. It made the method even faster as well.

Kylart · 2022-11-28T00:37:31Z

src/users.js

+  const fav = $('#anime_favorites .fs10')
+  if ($(fav).text() !== '') { // check if there are no favorites
+    const favAnime = []
+    fav.each(function () {
+      favAnime.push($(this).text())
+    })
+    result.push({ FavoriteAnime: favAnime })
+  }
+  const fav2 = $('#manga_favorites .fs10')
+  if ($(fav2).text() !== '') { // check if there are no favorites
+    const favManga = []
+    fav2.each(function () {
+      favManga.push($(this).text())
+    })
+    result.push({
+      FavoriteManga: favManga
+    })
+  }
+  const fav3 = $('#character_favorites .fs10')
+  if ($(fav3).text() !== '') { // check if there are no favorites
+    const favChar = []
+    fav3.each(function () {
+      favChar.push($(this).text())
+    })
+    result.push({
+      FavoriteCharacters: favChar
+    })
+  }
+  const fav4 = $('.favmore .fs10')
+  if ($(fav4).text() !== '') { // check if there are no favorites
+    const favPeople = []
+    fav4.each(function () {
+      favPeople.push($(this).text())
+    })
+    result.push({
+      FavoritePeople: favPeople
+    })
+  }


This is kinda annoying to read.
Please rename fav, fav1 etc.. to relevant names like fav -> favAnimes, fav2 -> favManga` or something like that.

Also, it would be great to have each fav in its own method.

added an addFavorites method on 01d4c6d
I hope it makes it way easier to read the code.

Kylart · 2022-11-28T17:42:09Z

I forgot to mention this but can you change the result properties names to use camelCase instead of PascalCase? This way it's coherent with the prest of the package.

StavrosNik4 · 2022-11-29T15:34:45Z

I added a camelize method in d357f88, for some reason camelCase() didn't work.
@Kylart I think I fix everything, do you believe we are ready to proceed to the merging or should I provide more documentation as well?
I don't think I have that much time right now to add tests. I will add them once I have more time.

Kylart

Thank you very much for this contributions! I'll ship it with the next release whenever I have some time.

Would be great if you could add tests in another PR later 😄

StavrosNik4 added 8 commits November 8, 2022 03:38

getUser method

e066cde

users.parsePage() method remake

c179606

get bio added

d3d70c9

added get user stats

32c55e9

added get favorite anime/manga etc

a4d69ac

final documentation

a2b45a4

Delete test.js

235c656

final documentation

c54beed

StavrosNik4 mentioned this pull request Nov 26, 2022

Fetching user info in getWatchListFromUser #63

Open

Kylart requested changes Nov 28, 2022

View reviewed changes

StavrosNik4 added 2 commits November 28, 2022 19:09

made result an object and used assign instead of push

4fe816c

made addFavorites method

01d4c6d

StavrosNik4 added 2 commits November 29, 2022 17:25

changed the way that I add user status. Also added camelize method.

d357f88

documentation

b6351c6

Kylart approved these changes Nov 30, 2022

View reviewed changes

Kylart merged commit f832492 into Kylart:dev Nov 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Created getUser() method #85

Created getUser() method #85

StavrosNik4 commented Nov 26, 2022

Kylart left a comment

Kylart Nov 28, 2022

StavrosNik4 Nov 28, 2022

Kylart Nov 28, 2022

StavrosNik4 Nov 28, 2022

StavrosNik4 Nov 29, 2022

Kylart Nov 28, 2022

StavrosNik4 Nov 28, 2022

Kylart Nov 28, 2022

StavrosNik4 Nov 28, 2022

Kylart commented Nov 28, 2022

StavrosNik4 commented Nov 29, 2022 •

edited

Loading

Kylart left a comment

Created getUser() method #85

Created getUser() method #85

Conversation

StavrosNik4 commented Nov 26, 2022

Kylart left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Kylart commented Nov 28, 2022

StavrosNik4 commented Nov 29, 2022 • edited Loading

Kylart left a comment

Choose a reason for hiding this comment

StavrosNik4 commented Nov 29, 2022 •

edited

Loading