Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KX-58552 KXI-58552 Add structuredText to VSCode extension for Python #526

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

acheung12
Copy link
Collaborator

Changes introduced by this PR

  • Added support for toStructuredText format in vscode evaluate function.
  • Tested using local q tests found in scratchpad EDI.quke
  • evaluate function parameters changed, will need different params to work. Not backwards compatible
  • added the option for text, serialized, and structuredText

@acheung12 acheung12 self-assigned this Feb 18, 2025
@acheung12
Copy link
Collaborator Author

I did find some bugs with this code.

First off, it looks like that symbols are populating the symbol space when serialize is being chosen when converting a python string. This may need to be resolved as I am not sure if we would want this.

It also looks like the api we area using for python toStrructuredText may be an older version compared to the q toStructuredText. Should we update this current ticket to get it up to speed or create a separate ticket as the api will need to be updated in the scratchpad as well?

@acheung12 acheung12 marked this pull request as draft February 18, 2025 13:48
@acheung12 acheung12 requested a review from ecmel February 18, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant