fix一些问题 #54
Open
fix一些问题 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
适配x86支持 fix android R StripHprof 模式native崩溃问题
| primitiveArrayDumpIndex + BASIC_TYPE_BYTE_SIZE /*value type*/; | ||
| } | ||
| arraySerialNo++; | ||
| // if (isCurrentSystemHeap) { |
There was a problem hiding this comment.
裁剪模式会导致分析的时候出现问题，并且也不需要这块的分析
There was a problem hiding this comment.
这里是为了裁剪掉更多的heap，如果注释掉了，会导致裁剪的内容变少。具体出现的问题是什么？
| xhook_register("libart.so", "write", (void *)hook_write, nullptr); | ||
| xhook_register("libbase.so", "write", (void *)hook_write, nullptr); | ||
| xhook_register("libartbase.so", "write", (void *)hook_write, nullptr); | ||
| if (sdk_version == 30) { |
There was a problem hiding this comment.
为啥要特判30呢，这两个函数原本不是也hook了吗
There was a problem hiding this comment.
30 不需要hook其他的，只要hook 2个就可以了，（我们还有其他的hook尽量少吧，也可以不判断，对程序结果不影响）
There was a problem hiding this comment.
如果这里特判了，其他版本感觉也要特判。但是可能会导致有些不遵守规范的rom版本用不了有问题，比如是6.0的android版本，但是实际上是5.0的虚拟机so
| @@ -38,7 +39,7 @@ | |||
| public ForkJvmHeapDumper() { | |||
| soLoaded = KGlobalConfig.getSoLoader().loadLib("koom-java"); | |||
| if (soLoaded) { | |||
| initForkDump(); | |||
| initForkDump(Build.VERSION.SDK_INT); | |||
| @@ -60,6 +61,19 @@ public boolean dump(String path) { | |||
| return false; | |||
| } | |||
|
|
|||
| //modify file permission, adapt to some rom | |||
There was a problem hiding this comment.
这里能说下具体哪些rom有哪些不兼容的现象吗
There was a problem hiding this comment.
meizu 16T 和 oppo r11 2台手机我们这边都不行
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
适配x86支持
适配某些手机无权限分析文件
fix android R StripHprof 模式native崩溃问题