Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask secret data in preview result #1176

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

liu-hm19
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR masks the data and stringData in kusion preview result.

Which issue(s) this PR fixes:

Fixes #1174

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., design docs, usage docs, etc.:


@liu-hm19 liu-hm19 added the kind/feature Categorizes issue or PR as related to a new feature label Jun 21, 2024
@liu-hm19 liu-hm19 added this to the v0.12.1 milestone Jun 21, 2024
@liu-hm19 liu-hm19 requested a review from SparkYuan June 21, 2024 09:09
@liu-hm19 liu-hm19 self-assigned this Jun 21, 2024
@coveralls
Copy link

coveralls commented Jun 21, 2024

Pull Request Test Coverage Report for Build 9611810421

Details

  • 81 of 110 (73.64%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 54.329%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/diff/diff.go 81 110 73.64%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9610443685: 0.1%
Covered Lines: 9181
Relevant Lines: 16899

💛 - Coveralls

pkg/util/diff/diff.go Outdated Show resolved Hide resolved
pkg/util/diff/diff.go Outdated Show resolved Hide resolved
pkg/util/diff/diff.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9709719978

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 83 of 116 (71.55%) changed or added relevant lines in 1 file are covered.
  • 378 unchanged lines in 9 files lost coverage.
  • Overall coverage decreased (-0.02%) to 54.162%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/diff/diff.go 83 116 71.55%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
pkg/engine/operation/preview.go 4 78.26%
pkg/engine/operation/parser/spec_parser.go 4 56.1%
pkg/secrets/providers.go 8 67.74%
pkg/config/validation.go 10 75.65%
pkg/apis/api.kusion.io/v1/types.go 14 0.0%
pkg/cmd/preview/preview.go 52 39.57%
pkg/engine/operation/graph/resource_node.go 98 55.96%
pkg/cmd/apply/apply.go 185 50.3%
Totals Coverage Status
Change from base Build 9610443685: -0.02%
Covered Lines: 9200
Relevant Lines: 16986

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 28, 2024

Pull Request Test Coverage Report for Build 9710845116

Details

  • 105 of 116 (90.52%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 54.184%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/util/diff/diff.go 105 116 90.52%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 79.27%
Totals Coverage Status
Change from base Build 9710426125: 0.2%
Covered Lines: 9247
Relevant Lines: 17066

💛 - Coveralls

Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan enabled auto-merge (squash) June 28, 2024 09:55
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit 884ff58 into KusionStack:main Jun 28, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: mask secret data in kusion preview result
3 participants