Skip to content

Commit

Permalink
fix: wrong release workflow as dirty git state (#433)
Browse files Browse the repository at this point in the history
## What type of PR is this?
/kind bug

## What this PR does / why we need it:

fix wrong release workflow as dirty git state
  • Loading branch information
elliotxx authored May 17, 2024
1 parent 0300474 commit ee39a69
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ jobs:
# It bypasses the 'process.env.CI = true' setting in CI environments
# that treats warnings as errors, ensuring a successful build.
CI=false npm run build
touch build/.gitkeep
- name: Release the karpor with GoReleaser
uses: goreleaser/goreleaser-action@v2
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ __debug_bin
# build
dist/
build/
ui/build/*
!ui/build/.gitkeep
_build/

# log
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ build-server-windows: ## Build server for Windows
.PHONY: build-ui
build-ui: ## Build UI for the dashboard
@echo "Building UI for the dashboard ..."
cd ui && npm install && npm run build
cd ui && npm install && npm run build && touch build/.gitkeep

.PHONY: check-license
check-license: ## Checks if repo files contain valid license header
Expand Down
2 changes: 0 additions & 2 deletions ui/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,5 @@
/config/config.local.ts
/yarn.lock
/.nyc_output
/build
.DS_Store
/src/.DS_Store

0 comments on commit ee39a69

Please sign in to comment.