[UtilitiesBundle] Fix deprecated urltransationnamingstrategy (#3036)

* [UtilitiesBundle] Fix deprecated urltransationnamingstrategy Co-authored-by: Merel Jossart <[email protected]> Co-authored-by: Jeroen Thora <[email protected]>
Kunstmaan · Nov 18, 2021 · 0412d96 · 0412d96
1 parent dab81f8
commit 0412d96
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/UPGRADE-5.10.md b/UPGRADE-5.10.md
@@ -32,6 +32,8 @@ Together with the CSRF token some of those routes will only be available to post
 * `Kunstmaan\MediaBundle\Controller\FolderController::deleteAction`
 * `Kunstmaan\MediaBundle\Controller\MediaController::deleteAction`
 
+* We have updated the `\Kunstmaan\UtilitiesBundle\Helper\UrlTransactionNamingStrategy` class to be compatible with `ekino/newrelic-bundle` 2.0. If you use this class upgrade the newrelic bundle in your project.
+
 AdminBundle
 ------------
 

diff --git a/composer.json b/composer.json
@@ -79,7 +79,7 @@
     "require-dev": {
         "symfony/debug": "^3.4.21|^4.4",
         "fakerphp/faker": "^1.15",
-        "ekino/newrelic-bundle": "^1.4",
+        "ekino/newrelic-bundle": "^2.3",
         "matthiasnoback/symfony-config-test": "^4.0",
         "matthiasnoback/symfony-dependency-injection-test": "^4.1",
         "symfony/phpunit-bridge": "^5.2",

diff --git a/src/Kunstmaan/UtilitiesBundle/Helper/UrlTransactionNamingStrategy.php b/src/Kunstmaan/UtilitiesBundle/Helper/UrlTransactionNamingStrategy.php
@@ -2,13 +2,14 @@
 
 namespace Kunstmaan\UtilitiesBundle\Helper;
 
-use Ekino\Bundle\NewRelicBundle\TransactionNamingStrategy\TransactionNamingStrategyInterface;
+use Ekino\NewRelicBundle\TransactionNamingStrategy\TransactionNamingStrategyInterface;
 use Symfony\Component\HttpFoundation\Request;
 
 class UrlTransactionNamingStrategy implements TransactionNamingStrategyInterface
 {
-    public function getTransactionName(Request $request)
+    public function getTransactionName(Request $request): string
     {
         return $request->getPathInfo();
     }
 }
+
diff --git a/src/Kunstmaan/UtilitiesBundle/composer.json b/src/Kunstmaan/UtilitiesBundle/composer.json
@@ -36,10 +36,10 @@
         "matthiasnoback/symfony-dependency-injection-test": "^4.1",
         "symfony/phpunit-bridge": "^5.1",
         "phpunit/phpunit": "^8.5",
-        "ekino/newrelic-bundle": "^1.4"
+        "ekino/newrelic-bundle": "^2.3"
     },
     "suggest": {
-        "ekino/newrelic-bundle": "To use the UrlTransactionNamingStrategy"
+        "ekino/newrelic-bundle": "Require ^2.0 to use the UrlTransactionNamingStrategy"
     },
     "autoload": {
         "psr-4": { "Kunstmaan\\UtilitiesBundle\\": "" }