Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift to V1 #11

Merged
merged 3 commits into from
Jan 27, 2025
Merged

Shift to V1 #11

merged 3 commits into from
Jan 27, 2025

Conversation

KulikDM
Copy link
Owner

@KulikDM KulikDM commented Jan 27, 2025

Submissions Basics:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you checked all Issues to tie the PR to a specific one?

Type of Change:

  • Bug fix
  • New feature
  • Documentation update

All Submissions Cores:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new unit tests for your changes?
  • Do all new and existing unit tests pass locally?

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 99.40387% with 12 lines in your changes missing coverage. Please review.

Project coverage is 98.53%. Comparing base (5d9b340) to head (082bbd7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
pythresh/thresholds/meta.py 80.64% 4 Missing and 2 partials ⚠️
pythresh/thresholds/base.py 88.37% 4 Missing and 1 partial ⚠️
pythresh/thresholds/comb.py 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #11      +/-   ##
==========================================
- Coverage   98.53%   98.53%   -0.01%     
==========================================
  Files          71       71              
  Lines        3219     4293    +1074     
  Branches      157      307     +150     
==========================================
+ Hits         3172     4230    +1058     
- Misses         21       39      +18     
+ Partials       26       24       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KulikDM KulikDM merged commit 7fa8fdc into main Jan 27, 2025
14 checks passed
@KulikDM KulikDM deleted the sklearn-compat branch January 27, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant