assert grpc call errors #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eguzki Astiz Lezaun <[email protected]>
eguzki
force-pushed
the
assert-grpc-call-errors
branch
from
faa1487 to
f022ba0
Compare
alexsnaps
reviewed
Nov 28, 2024
alexsnaps
reviewed
Nov 28, 2024
| request, | ||
| timeout_milliseconds, | ||
| ) | ||
| .unwrap_or(Ok(0)); |
There was a problem hiding this comment.
You seem to change this for a Err now, to get the previous behavior... that was already confusing, but that's now a new pattern, I don't think this makes sense...
There was a problem hiding this comment.
So why the Result here? if the Err path gets dropped on the floor?
There was a problem hiding this comment.
It get rewrapped in an Option::Some always... Now I get it
There was a problem hiding this comment.
... other than when it isn't expected...
alexsnaps
reviewed
Nov 28, 2024
alexsnaps
reviewed
Nov 28, 2024
alexsnaps
approved these changes
Nov 28, 2024
|
I was thinking we should bring these changes to proxy-wasm#17 wdyt @alexsnaps ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect from the GRPC call to return error as well.