Added more resilience on update policies. #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Cristurean <[email protected]>
Signed-off-by: Alexander Cristurean <[email protected]>
Signed-off-by: Alexander Cristurean <[email protected]>
Signed-off-by: Alexander Cristurean <[email protected]>
azgabur
reviewed
May 7, 2025
| import pytest | ||
|
|
||
| pytestmark = [pytest.mark.authorino] | ||
|
|
||
| logger = logging.getLogger(__name__) |
There was a problem hiding this comment.
What is the logging for here?
| authorization.identity.add_anonymous("anonymous") | ||
| authorization.wait_for_ready() | ||
| authorization.wait_until(has_observed_generation(generation + 1)) |
There was a problem hiding this comment.
You still need the wait_for_ready as just waiting for Authorino to pick up the the AuthPolicy is not enough. The observedGeneration can be incremented but the Policy can be in status "Not Enforced". wait_for_ready makes sure the Policy is also "Enforced"
| authorization.identity.add_anonymous("anonymous") | ||
| authorization.wait_for_ready() | ||
| authorization.wait_until(has_observed_generation(generation + 1)) |
There was a problem hiding this comment.
I would put the wait for generation == observedGeneration inside wait_for_ready in class Policy as it conceptually fits there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check function that will assert the generation has been incremented before confirming it the policy enforcement.