Fix AuthPolicy attachment to Gateway instead of HTTPRoute #633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azgabur
requested changes
Feb 17, 2025
Signed-off-by: emmaaroche <[email protected]>
emmaaroche
force-pushed
the
gateway-policy-attach-fix
branch
from
f438ddc to
f31f689
Compare
averevki
approved these changes
Feb 17, 2025
azgabur
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR ensures that the
AuthPolicyis attached to theGatewayinstead of theHTTPRoute, fixing the unintended behavior in some tests.Changes Made
authorizationfixture intestsuite/tests/singlecluster/gateway/conftest.pyto usegatewayas the target reference.authorizationfixture that was used to override the AuthPolicy intest_update_authpolicy_target_ref.py.Related Issue
#630