Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy) #622

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

emmaaroche
Copy link
Contributor

Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy)

@emmaaroche emmaaroche requested a review from averevki January 21, 2025 14:32
@emmaaroche emmaaroche force-pushed the test-change-parentref branch 3 times, most recently from 4dbcc75 to 5edc14b Compare January 27, 2025 15:20
@emmaaroche emmaaroche force-pushed the test-change-parentref branch from b807697 to d66e9b5 Compare January 31, 2025 16:59
@emmaaroche emmaaroche force-pushed the test-change-parentref branch 2 times, most recently from 38cfcac to cb69252 Compare February 11, 2025 12:45
@emmaaroche emmaaroche self-assigned this Feb 11, 2025
@emmaaroche emmaaroche marked this pull request as ready for review February 11, 2025 15:54
@emmaaroche emmaaroche added the Test case New test case label Feb 11, 2025
@emmaaroche emmaaroche force-pushed the test-change-parentref branch from cb69252 to 2e3e201 Compare February 12, 2025 12:03
Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great first PR! I have just few nitpicks

@emmaaroche emmaaroche force-pushed the test-change-parentref branch from 2e3e201 to 86e4d8f Compare February 13, 2025 16:52
Copy link
Contributor

@azgabur azgabur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on first PR!

@emmaaroche emmaaroche merged commit 4e271a3 into Kuadrant:main Feb 14, 2025
3 checks passed
@emmaaroche emmaaroche deleted the test-change-parentref branch February 14, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Test case New test case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants