-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy) #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4dbcc75
to
5edc14b
Compare
averevki
reviewed
Jan 27, 2025
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
b807697
to
d66e9b5
Compare
averevki
reviewed
Feb 6, 2025
testsuite/tests/singlecluster/gateway/reconciliation/test_change_parentref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
38cfcac
to
cb69252
Compare
averevki
reviewed
Feb 11, 2025
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
...s/singlecluster/gateway/reconciliation/change_targetref/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...s/singlecluster/gateway/reconciliation/change_targetref/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...glecluster/gateway/reconciliation/change_targetref/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...glecluster/gateway/reconciliation/change_targetref/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
cb69252
to
2e3e201
Compare
azgabur
reviewed
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first PR! I have just few nitpicks
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Outdated
Show resolved
Hide resolved
testsuite/tests/singlecluster/gateway/reconciliation/change_targetref/conftest.py
Show resolved
Hide resolved
...s/singlecluster/gateway/reconciliation/change_targetref/test_update_authpolicy_target_ref.py
Show resolved
Hide resolved
...glecluster/gateway/reconciliation/change_targetref/test_update_ratelimitpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
...s/singlecluster/gateway/reconciliation/change_targetref/test_update_authpolicy_target_ref.py
Outdated
Show resolved
Hide resolved
…itPolicy) Signed-off-by: emmaaroche <[email protected]>
2e3e201
to
86e4d8f
Compare
azgabur
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job on first PR!
averevki
approved these changes
Feb 14, 2025
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test for changing parentRef field in policies (AuthPolicy and RateLimitPolicy)