Nightly update pipeline using Helm deploy #50
Conversation
azgabur
force-pushed
the
deploy
branch
2 times, most recently
from
e3eaae4
to
c7d6db7
Compare
|
Tools do not need redeploy. The helm-install-nightly pipeline can just reinstall kuadrant and keep tools deployed as they were. That needs sparation of tools deploy with |
|
@azgabur It would be nice to squash commits ;) |
deploy/pipeline-nightly-update.yaml
Outdated
| name: kube-api | ||
| type: string | ||
| - description: Istio deployment. Only these values 'sail', 'ossm', 'ossm3' | ||
| name: istioProvider |
There was a problem hiding this comment.
| name: istioProvider | |
| name: istio-provider |
tasks/02-uninstall.yaml
Outdated
| - uninstall | ||
| - -n=default | ||
| - --ignore-not-found | ||
| - --wait | ||
| - kuadrant-operators |
There was a problem hiding this comment.
inline commands are more readable
There was a problem hiding this comment.
I inlined the shorter commands but the helm commands are kinda long and I think it helps readability in that case. I refactored the helm commands to multi-line so maybe its better now?
There was a problem hiding this comment.
I changed the helm commands back as they are more readable that way
tasks/01-clone.yaml
Outdated
| limits: | ||
| cpu: 250m | ||
| memory: 128Mi | ||
| image: quay.io/rhn_support_azgabur/alpine/k8s:1.31.2 |
There was a problem hiding this comment.
can you link a :latest image here, so we don't have to update this every time image changes?
deploy/pipeline.yaml
Outdated
| name: kube-api | ||
| type: string | ||
| - description: Kuadrant image url | ||
| name: indexImage |
There was a problem hiding this comment.
there is a convention for the names
| name: indexImage | |
| name: index-image |
tasks/01-clone.yaml
Outdated
| - https://github.com/azgabur/kuadrant-helm-install | ||
| - $(workspaces.shared-workspace.path)/kuadrant-helm-install | ||
| command: | ||
| - git |
There was a problem hiding this comment.
I'm using /bin/bash everywhere else for the command. I don't see a good reason to juggle between different commands and not to just use bash -c "git ..." with whatever arguments u want
tasks/01-clone.yaml
Outdated
There was a problem hiding this comment.
go by the convention on tasks names please e.g. clone-task.yaml, uninstall-kuadrant-task.yaml, etc.
tasks/kustomization.yaml
Outdated
There was a problem hiding this comment.
I rly want pipelines to have independent deployment if possible. Nightly and release pipelines do not require helm tasks to work, so it'll be good to not install them as a collection.
You can try an approach with differently named kustomization files, for different pipelines, or different directory for the helm tasks
Signed-off-by: Alex Zgabur <[email protected]>
azgabur
force-pushed
the
deploy
branch
7 times, most recently
from
40c0ce2
to
68dd606
Compare
| - name: istio-provider | ||
| value: ossm3 | ||
| - name: kube-api | ||
| value: https://kubernetes.default |
There was a problem hiding this comment.
The login task has problem with this url - the sed command, can it be fixed in future PR? @averevki
Signed-off-by: Alex Zgabur <[email protected]>
|
Now you really really can do re-review :) |
Signed-off-by: Alex Zgabur <[email protected]>
Replaces #39
Closes #41
This nightly-update-pipeline can update specified cluster to newest nightly using helm deploy.
The deploy pipeline can install any choosen Kuadrant image on specified cluster.
Done:
image,channelof kuadrant and maybe other variables