Skip to content

Commit

Permalink
BUILD(server): allow users to specify the UID/GID for the murmur user
Browse files Browse the repository at this point in the history
the the docker image that is built by default uses murmur user to run
the server. When users use bind mount volumes, the host system is
expected to match the permissions (UID/GID) of the created murmur user
or else they will get permission errors

this change allows users who build the docker image to specify which
user id and group id to be used in the docker image

Closes mumble-voip#5634
  • Loading branch information
Paulo Erichsen committed Apr 24, 2022
1 parent aae451a commit adbdf14
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 3 deletions.
6 changes: 5 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,12 @@ RUN make -j $(nproc)
FROM ubuntu:focal

ARG DEBIAN_FRONTEND=noninteractive
ARG UID=1000
ARG GID=1000

RUN groupadd --gid $GID murmur \
&& useradd --uid $UID --gid $GID murmur

RUN adduser murmur
RUN apt-get update && apt-get install --no-install-recommends -y \
libcap2 \
libzeroc-ice3.7 \
Expand Down
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
![Mumble screenshot](screenshots/Mumble.png)

# Mumble - Open Source voice-chat software
# Mumble - Open Source voice-chat software

[![https://www.mumble.info](https://img.shields.io/badge/Website-https%3A%2F%2Fwww.mumble.info-blue?style=for-the-badge)](https://www.mumble.info)

Expand Down Expand Up @@ -120,11 +120,16 @@ murmurd [-supw <password>] [-ini <inifile>] [-fg] [v]
#### Build and run from Docker

On recent Docker versions you can build images directly from sources on GitHub:
```
```bash
docker build --pull -t mumble-server github.com/mumble-voip/mumble#master
```
Example `--pull`s each time to check for updated base image, then downloads and builds `master` branch.

You can also specify user id (UID) and group id (GID) for the *murmur* user in the image. This allows users who use bind mount volumes to use the same UID/GID in the container as in the host:
```bash
docker build --pull -t mumble-server --build-arg UID=1234 --build-arg GID=1234 github.com/mumble-voip/mumble#master
```

### OpenGL Overlay

The OpenGL overlay works by intercepting the call to switch buffers, and just
Expand Down

0 comments on commit adbdf14

Please sign in to comment.