Skip to content

Commit

Permalink
Merge PR mumble-voip#5893: FIX(server, rpc): Don't send useless UserS…
Browse files Browse the repository at this point in the history
…tate message

As it was, the sent UserState message would have only contained the user's session ID, which in and of itself is absolutely useless. Thus, it is better to not send a UserState message in this case.
  • Loading branch information
Krzmbrzl authored Sep 22, 2022
2 parents 40f2edb + 93019fd commit 600ffb4
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions src/murmur/RPC.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -408,10 +408,6 @@ void Server::setListenerVolumeAdjustment(ServerUser *user, const Channel *cChann
MumbleProto::UserState mpus;
mpus.set_session(user->uiSession);

if (!broadcastListenerVolumeAdjustments) {
sendExcept(user, mpus);
}

MumbleProto::UserState::VolumeAdjustment *volume_adjustment = mpus.add_listening_volume_adjustment();
volume_adjustment->set_listening_channel(cChannel->iId);
volume_adjustment->set_volume_adjustment(volumeAdjustment.factor);
Expand Down

0 comments on commit 600ffb4

Please sign in to comment.