Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop creating useless file in home directory - resolves #82 #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

magnus-ISU
Copy link

This should be done with care. I see no reason why the program should have been doing this. However, maybe there was a reason and I haven't looked at the codebase hard enough.

That said, it runs exactly the same, and I can think of no reason why it should have been the way it was.

@KrispyCamel4u
Copy link
Owner

Hi, there is a use of this file for using the theme_setter(for which rooter.py is required). It was done a long time before with a hackyy way of implementation when I was not aware of Glib::settings. But now as you reminded me, the purpose of this file can be greatly achieved with Glib::settings.

@magnus-ISU
Copy link
Author

So should this branch be merged? Or is it breaking some functionality?

@KrispyCamel4u
Copy link
Owner

This will break one functionality at the moment. So as of now, it can't be merged, but thanks for reminding this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants