Enable optional customization of route prefix

Krisell · Nov 23, 2019 · a718970 · a718970
1 parent 1aaf3c3
commit a718970
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 8 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,3 +1,4 @@
 vendor
 **/**.cache
 build
+.phpunit*
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -16,5 +16,6 @@
     </testsuites>
     <php>
         <env name="VERSION" value="TESTING_VALUE"/>
+        <env name="VERSION_ROUTE_PREFIX" value="dev-custom"/>
     </php>
 </phpunit>
diff --git a/src/DeployedVersionServiceProvider.php b/src/DeployedVersionServiceProvider.php
@@ -10,13 +10,14 @@ class DeployedVersionServiceProvider extends ServiceProvider
 {
     public function boot()
     {
-        Route::get('/version', VersionController::class);
+        Route::get(config('deployed-version.route-prefix') . '/version', VersionController::class);
     }
 
     public function register()
     {
         $this->mergeConfigFrom(
-            __DIR__.'/config/deployed-version.php', 'deployed-version'
+            __DIR__.'/config/deployed-version.php',
+            'deployed-version'
         );
     }
 }
diff --git a/src/config/deployed-version.php b/src/config/deployed-version.php
@@ -2,4 +2,5 @@
 
 return [
   'version' => env('VERSION', 'NONE'),
-];
+  'route-prefix' => env('VERSION_ROUTE_PREFIX', '')
+];
diff --git a/tests/DeployedVersionTest.php b/tests/DeployedVersionTest.php
@@ -12,21 +12,21 @@ protected function getPackageProviders($app)
     }
 
     /** @test */
-    public function the_version_route_is_added()
+    public function the_version_route_is_added_and_uses_prefix_set_in_env()
     {
-        $this->get('/version')->assertStatus(200);
+        $this->get('dev-custom/version')->assertStatus(200);
     }
 
     /** @test */
     public function the_default_version_is_TESTING_VALUE()
     {
-        $this->get('/version')->assertJson(['version' => 'TESTING_VALUE']);
+        $this->get('dev-custom/version')->assertJson(['version' => 'TESTING_VALUE']);
     }
 
     /** @test */
     public function the_version_can_be_set_in_the_environment()
     {
         config(['deployed-version.version' => 'NEW_TESTING_VALUE']);
-        $this->get('/version')->assertJson(['version' => 'NEW_TESTING_VALUE']);
+        $this->get('dev-custom/version')->assertJson(['version' => 'NEW_TESTING_VALUE']);
     }
-}
+}