Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GeoMechanicsApplication] Fix issues in integration tests hindering a coverage report for them #13084

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rfaasse
Copy link
Contributor

@rfaasse rfaasse commented Feb 3, 2025

These changes are needed to get coverage output for the python tests using llvm-cov

@rfaasse rfaasse requested a review from avdg81 February 3, 2025 16:01
@rfaasse rfaasse marked this pull request as ready for review February 3, 2025 16:02
Copy link
Contributor

@avdg81 avdg81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small, yet important step towards making code coverage analysis with llvm-cov easier. Thank you for figuring out which tests needed to be fixed for a successful code coverage run. I have one very minor suggestion, so we're almost ready to merge this patch :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume that the white space changes in this file were unintended. Can you please revert them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GeoMechanicsApplication] Investigate the coverage of the "small" and "nightly" test suites
2 participants